Register

Leafkiller's 4.3 Feral Ovale Script

Face-rippin fun.

Moderator: Forum Administrators

Posts: 6
Joined: Wed Mar 23, 2011 7:04 am

Re: Leafkiller's 4.3 Feral Ovale Script

Postby Klötenpeter » Tue Dec 13, 2011 9:48 am

Thank you for providing this script. I am a big fan and use it since I started to dps as kitty. But I have a problem with the current Version 4.3.2: it never recommends to use Ravage. I had this problem since a while and started to test older version of the script because it worked once. Version 4.2.13 is the last where Ravage is shown for me and it even works with the 4T13 bonus. Would be nice if you could look into this issue :)

Exalted
User avatar
Posts: 1145
Joined: Fri Jun 04, 2010 4:28 am

Re: Leafkiller's 4.3 Feral Ovale Script

Postby Leafkiller » Tue Dec 13, 2011 2:06 pm

Klötenpeter wrote:Thank you for providing this script. I am a big fan and use it since I started to dps as kitty. But I have a problem with the current Version 4.3.2: it never recommends to use Ravage. I had this problem since a while and started to test older version of the script because it worked once. Version 4.2.13 is the last where Ravage is shown for me and it even works with the 4T13 bonus. Would be nice if you could look into this issue :)


I just checked and for the feral charge stampede with the "4 Piece T13" checked off both conditions are working on my toon. Can you link me your armory and check the conditions you have enabled in the script? I don't have 4 piece to test with. As a side note, the newest version of Ovale has implemented auto detect for tier 13 so I will be removing the two T13 toggles shortly.

Exalted
User avatar
Posts: 1145
Joined: Fri Jun 04, 2010 4:28 am

Re: Leafkiller's 4.3 Feral Ovale Script

Postby Leafkiller » Tue Dec 13, 2011 3:36 pm

Version 4.3.3 posted. It auto-detects T13 set bonuses, but requires the most recent release of Ovale.

Posts: 5
Joined: Thu Jun 30, 2011 3:16 am

Re: Leafkiller's 4.3 Feral Ovale Script

Postby Reverie » Tue Dec 13, 2011 4:34 pm

Hi Leafkiller.

I noticed you said the 4pT13 checkbox should suggest using (Stampede) Ravage! before suggesting to use TF, however I'm not seeing this happen. Yes, I do have the most up-to-date script and yes I have 4pT13 checked in options. If my TF is off CD, and I FC a mob (regardless of before or after TF comes off CD), the script seems to always suggest TF over using the (currently available) Ravage!.

(Edit) I have updated the script to 4.3.3 and updated to the newest version of Ovale, 4.3.1, but this issue persists.
Last edited by Reverie on Tue Dec 13, 2011 6:14 pm, edited 1 time in total.

Posts: 6
Joined: Wed Mar 23, 2011 7:04 am

Re: Leafkiller's 4.3 Feral Ovale Script

Postby Klötenpeter » Tue Dec 13, 2011 5:07 pm

Leafkiller wrote:I just checked and for the feral charge stampede with the "4 Piece T13" checked off both conditions are working on my toon. Can you link me your armory and check the conditions you have enabled in the script? I don't have 4 piece to test with. As a side note, the newest version of Ovale has implemented auto detect for tier 13 so I will be removing the two T13 toggles shortly.

Armory: http://eu.battle.net/wow/en/character/blackmoore/otti/advanced

4.3.2: http://i.imgur.com/ySP28.jpg
4.3.3: http://i.imgur.com/b4PHt.jpg

As you can see on the screenshots, Stampede is still active while the buff from TF runs out.

It works with 4.2.13 though: http://i.imgur.com/WZguA.jpg

Exalted
User avatar
Posts: 1145
Joined: Fri Jun 04, 2010 4:28 am

Re: Leafkiller's 4.3 Feral Ovale Script

Postby Leafkiller » Tue Dec 13, 2011 6:36 pm

Here is what is happening. The logic on using up the Stampede proc during TF is more restrictive now that it used to be - and with 4 piece T13, you will see this logic exercised a lot. My old script did not check of OOC or going above 100 energy when telling you to cast Ravage! while the new code ensures you won't energy cap when casting Ravage!, even if this will cause the Ravage! to miss the TF window. There is protective code that keeps you from wasting the Stampede proc that kicks in with 3 seconds left, but that will happen after TF has expired.

Per Mew, removing the energy capping code is a dps loss (around 50dps in my current gear if I toggle on the 4 piece set bonus).

I did find that the OOC check that was part of the TF+Stampede code was not needed so I removed that, but it does have the energy cap check. This is in a new version I posted - 4.3.4

Posts: 6
Joined: Wed Mar 23, 2011 7:04 am

Re: Leafkiller's 4.3 Feral Ovale Script

Postby Klötenpeter » Wed Dec 14, 2011 6:13 am

Ravage is never recommended for me, neither when TF nor Stampede are about to expire. Here is a screenshot from the 4.3.4 version: http://i.imgur.com/ZcVs8.jpg

Exalted
User avatar
Posts: 1145
Joined: Fri Jun 04, 2010 4:28 am

Re: Leafkiller's 4.3 Feral Ovale Script

Postby Leafkiller » Wed Dec 14, 2011 1:42 pm

Since you have the 4 piece set bonus, I am going to assume you are referring to Stampede buffs caused by hitting Tiger's Fury. It is possible that the spell ID for that Stampede buff is different than the Spell ID that is generated from Feral Charge (which generates two different buffs depending on how many talent points you take). I still don't have the 4 piece set bonus so I have only been able to test the Feral Charge Stampede proc, and it is working for me. What I cannot explain is why an earlier version of the script is working for you though.

Just to be safe, can you download the addon "idTip", hit a TF, mouse over the Stampede buff on your UI and post the spell ID you are seeing? It is available on Curse.

Also, please don't use the 4.3.4 script in combat. It crashed on my last night when I went into bear form. Best guess is that I fat fingered something when I made the changes to do auto detection of tier 13.

Posts: 6
Joined: Wed Mar 23, 2011 7:04 am

Re: Leafkiller's 4.3 Feral Ovale Script

Postby Klötenpeter » Wed Dec 14, 2011 2:10 pm

Id is 81022 for both the Feral Charge Stampede buff and the TF Stampede Buff. Ravage is also not recommended when I use Feral Charge, it just never shows up.

Posts: 6
Joined: Wed Feb 16, 2011 9:41 am

Re: Leafkiller's 4.3 Feral Ovale Script

Postby Warscreamer » Wed Dec 14, 2011 3:30 pm

got something like:

Code: Select all
[20:28:01]Ovale: restant = 132947.992 attenteFinCast=132947.992
[20:28:01]Ovale: Action 5229 remains 132947.992
[20:28:01]Ovale: if return 132947.992,nil [1051]
[20:28:01]Ovale: if [1072]
[20:28:01]Ovale: Function List(1=bcd4,2=t5,) returned nil,nil,nil
[20:28:01]Ovale: if return nil  [1072]
[20:28:01]Ovale: group best action 5229 remains 132947.992,nil [1074]
[20:28:01]Ovale: if return 132947.992,nil [1076]
[20:28:01]Ovale: group best action 5229 remains 132947.992,nil [1077]
[20:28:01]Ovale: if return 132947.992,nil [1078]
[20:28:01]Ovale: CalculerMeilleureAction start = 132947.992
[20:28:01]Ovale: ****Master Node 8
[20:28:01]Ovale: group [1163]
[20:28:01]Ovale: if [1162]
[20:28:01]Ovale: Function CheckBoxOn(1=cooldownsR,) returned 0,nil,nil
[20:28:01]Ovale: group [1161]
[20:28:01]Ovale: if [1159]
[20:28:01]Ovale: Function Stance(1=3,) returned nil,nil,nil
[20:28:01]Ovale: if return nil  [1159]
[20:28:01]Ovale: if [1160]
[20:28:01]Ovale: Function Stance(1=1,) returned 0,nil,nil
[20:28:01]Ovale: group [1158]
[20:28:01]Ovale: if [1131]
[20:28:01]Ovale: Function List(1=bcd5,2=t0,) returned nil,nil,nil
[20:28:01]Ovale: if return nil  [1131]
[20:28:01]Ovale: if [1132]
[20:28:01]Ovale: Function List(1=bcd5,2=t1,) returned nil,nil,nil
[20:28:01]Ovale: if return nil  [1132]
[20:28:01]Ovale: if [1133]
[20:28:01]Ovale: Function List(1=bcd5,2=t2,) returned nil,nil,nil
[20:28:01]Ovale: if return nil  [1133]
[20:28:01]Ovale: if [1134]
[20:28:01]Ovale: Function List(1=bcd5,2=t3,) returned nil,nil,nil
[20:28:01]Ovale: if return nil  [1134]
[20:28:01]Ovale: if [1135]
[20:28:01]Ovale: Function List(1=bcd5,2=t4,) returned nil,nil,nil
[20:28:01]Ovale: if return nil  [1135]
[20:28:01]Ovale: if [1156]
[20:28:01]Ovale: Function List(1=bcd5,2=t5,) returned 0,nil,nil
[20:28:01]Ovale: group [1153]
[20:28:01]Ovale: if [1148]
[20:28:01]Ovale: GetTargetAura = start=nil end=nil stacks=0/1
[20:28:01]Ovale: Function BuffPresent(1=80951,) returned 0,0,nil
[20:28:01]Ovale: if return startA=endA  [1148]
[20:28:01]Ovale: unless
[20:28:01]Ovale: GetTargetAura = start=nil end=nil stacks=0/1
[20:28:01]Ovale: Function BuffPresent(1=80951,) returned 0,0,nil
[20:28:01]Ovale: group [1142]
[20:28:01]Ovale: if [1137]
[20:28:01]Ovale: GetTargetAura = start=nil end=nil stacks=0/3
[20:28:01]Ovale: Function DebuffPresent(1=33745,target=target,stacks=3,) returned 0,0,nil
[20:28:01]Ovale: if return startA=endA  [1137]
[20:28:01]Ovale: unless return nil,nil
[20:28:01]Ovale: group return nil
[20:28:01]Ovale: if return nil [1156]
[20:28:01]Ovale: group return nil
[20:28:01]Ovale: if return nil [1160]
[20:28:01]Ovale: group return nil
[20:28:01]Ovale: if return nil [1162]


after turning into bear form

Exalted
User avatar
Posts: 1145
Joined: Fri Jun 04, 2010 4:28 am

Re: Leafkiller's 4.3 Feral Ovale Script

Postby Leafkiller » Wed Dec 14, 2011 6:44 pm

@Warscreamer - I saw that last night. Just use the 4.3.2 version of the script (in the second post of this thread) until I get a chance to fix the script.

Honored
Posts: 97
Joined: Sun May 29, 2011 2:58 am

Re: Leafkiller's 4.3 Feral Ovale Script

Postby Terias » Thu Dec 15, 2011 4:06 am

I wanted to add confirmation, it is not recommending either ravage at all.

I can feral charge, and it will recommend berserk/tf before using the ravage. When I use berserk/tf it will never recommend using the ravage proc from tf at all (even if completely out of energy).

Using 4.3.2

Posts: 1
Joined: Thu Dec 15, 2011 6:56 am

Re: Leafkiller's 4.3 Feral Ovale Script

Postby Barboulis » Thu Dec 15, 2011 12:27 pm

Have a suggestion for an improvement in the mangle/shred filler logic :)

I modified my local Ovale copy to add a simple condition.
Code: Select all
   IsGrouped = function(condition)
      local grouped = GetRealNumPartyMembers()>0 or GetRealNumRaidMembers()>0
      return testbool(grouped, condition[1])
   end,
at the end of Condition.lua

Then the script has a slight change making it
Code: Select all
AddFunction AddCombo
{
   if CheckBoxOn(shred) {
        if IsGrouped(yes) Spell(SHRED)
        if IsGrouped(no) Spell(MANGLECAT)
   }
   if CheckBoxOff(shred) Spell(MANGLECAT)
}
This makes it so Mangle is automatically selected as filler when solo because most of the time you won't be able to position behind.

Script changes can be a little more involved too if this functionality is to be exposed to the user.
Code: Select all
AddCheckBox(manglesolo "Use Mangle for fillers (SOLO)" default mastery=2)
--
--
AddFunction AddCombo
{
   if CheckBoxOn(shred) {
        if IsGrouped(yes) or CheckBoxOff(manglesolo) Spell(SHRED)
        if IsGrouped(no) and CheckBoxOn(manglesolo) Spell(MANGLECAT)
   }
   if CheckBoxOff(shred) Spell(MANGLECAT)
}
This allows the user to select if they want the auto-switch to mangle as filler when solo functionality explicitly
instead of the script making the decision on its own.

Is this something useful? Should I put in a feature request with Ovale author?
Imho it would be nice to have conditions for all/most the macro conditionals in Ovale,
all I did was add a simplified version of the group:party/raid macro conditional.

Exalted
User avatar
Posts: 1613
Joined: Mon May 24, 2010 10:21 pm

Re: Leafkiller's 4.3 Feral Ovale Script

Postby Tinderhoof » Thu Dec 15, 2011 1:28 pm

Terias wrote:I wanted to add confirmation, it is not recommending either ravage at all.

I can feral charge, and it will recommend berserk/tf before using the ravage. When I use berserk/tf it will never recommend using the ravage proc from tf at all (even if completely out of energy).

Using 4.3.2

Using 4.3.2 last night during Zon'ozz attempts I was able to see the TF's Ravage recomended while the TF buff was still up. I did not see if it would recomend Ravage after TF ended but before Stampeed wore off. I will test this more tonight.

I mentioned this to Leaf last night and I was going to expand on it. The behavior I was seeing last night is consistant. When Stampeed is proc'd by FC and TF is off cooldown, TF is being recomended instead of Ravage. This behavior will show up mostly on the pull as you shouldn't see a lot of FC and TF perfectly sync'd the rest of the fight. Later during the fight when TF and FC were not sync'd I was seeing both Ravages being suggested as expected.

Exalted
User avatar
Posts: 1145
Joined: Fri Jun 04, 2010 4:28 am

Re: Leafkiller's 4.3 Feral Ovale Script

Postby Leafkiller » Thu Dec 15, 2011 6:38 pm

I posted 4.3.5. In it I fixed the bear crash bug (fat finger bug) and I made a small tweak to the Ravage! code. I don't have 4 piece yet so I cannot test that.

Some comments:

If TF is off of cooldown and you have < 45 energy, it will not use up an Existing Stampede proc; it will simply cast TF and overwrite the Stampede proc. I tested this in Mew and changing the rotation to make sure to always use up a Stampede proc even with low energy when TF is off of cooldown ends up being a dps loss. In general, the code to aggressively use up a Stampede proc will be what helps you use FC generated Stampede procs.

If you have tier 12 trinkets (like I do) at the start of a fight it is difficult to get energy low enough to hit TF/Berserk before the script suggests using up a FC generated Stampede proc.

For those with 4 piece, please test 4.3.5 and let me know how it is working for you.

Honored
Posts: 97
Joined: Sun May 29, 2011 2:58 am

Re: Leafkiller's 4.3 Feral Ovale Script

Postby Terias » Thu Dec 15, 2011 7:12 pm

No suggestions at all, none, with either 4.3.2 or 4.3.5. Using the most updated Ovale.

Not with high energy, low energy, no energy, low haste, desync'd fc/tf cooldowns, berserk up or down, all bleeds up, sr used and aggressive fb's unchecked.

My alt druid had an older script, 4.2.10 and it recommended Ravage correctly.

I'm getting neither the fc recommended ravage or the tf recommended ravage. It seems like it doesn't recognize I have the ravage buff at all after the script update. I was getting recommendations on my main using older scripts as well.

Other people may not be seeing ravage come up at an oppertune time, I'm not seeing it at all under any conditions.

To clarify, rather than showng ravage while I have the stampede buff, it is showing filler with a cooldown (the time remaining until I have the energy to shred).

Exalted
User avatar
Posts: 1145
Joined: Fri Jun 04, 2010 4:28 am

Re: Leafkiller's 4.3 Feral Ovale Script

Postby Leafkiller » Thu Dec 15, 2011 7:22 pm

Terias wrote:No suggestions at all, none, with either 4.3.2 or 4.3.5. Using the most updated Ovale.

Not with high energy, low energy, no energy, low haste, desync'd fc/tf cooldowns, berserk up or down, all bleeds up, sr used and aggressive fb's unchecked.

My alt druid had an older script, 4.2.10 and it recommended Ravage correctly.

I'm getting neither the fc recommended ravage or the tf recommended ravage. It seems like it doesn't recognize I have the ravage buff at all after the script update. I was getting recommendations on my main using older scripts as well.

Other people may not be seeing ravage come up at an oppertune time, I'm not seeing it at all under any conditions.

To clarify, rather than showng ravage while I have the stampede buff, it is showing filler with a cooldown (the time remaining until I have the energy to shred).


I don't get why that is happening. I am definitely seeing Stampede being recognized, and the code that has you cat Stampede when it only has 3 seconds left has not changed. If you test with no tier 13 and FC only, is that working?

I will build a version where I remove the energy thresholds - which is the only change to the TF/Stampede code and see what that does. I will post it in a minute.

Exalted
User avatar
Posts: 1145
Joined: Fri Jun 04, 2010 4:28 am

Re: Leafkiller's 4.3 Feral Ovale Script

Postby Leafkiller » Thu Dec 15, 2011 7:28 pm

Try this version and let me know what happens:

[code][/code]

Edit: snipped out the test code as this resolved now.

Honored
Posts: 97
Joined: Sun May 29, 2011 2:58 am

Re: Leafkiller's 4.3 Feral Ovale Script

Postby Terias » Thu Dec 15, 2011 7:31 pm

I don't think this is the priority, I think it's not recognizing the buff at all.

I have FC in my spec, I have only T13 on to remove most of my haste, FC with T13 off does not recommend ravage either.

I'm going to run the spellid mod you linked earlier.

Also: just ran the script you pasted, it did not recommend ravage at all. Ate my FC ravage with berserk, let that one fall off, then pooled energy until my 3rd ravage fell.

Edit: Reporting 81022 on both stampede procs.

Honored
Posts: 97
Joined: Sun May 29, 2011 2:58 am

Re: Leafkiller's 4.3 Feral Ovale Script

Postby Terias » Thu Dec 15, 2011 7:43 pm

I just spent a bit trying older scripts, 4.2.13 -> 4.2.14 is where the ravage recommendation broke. Ravage is recommended in 4.2.13 still, in 14 it refuses to recognize that the buff is up.

Exalted
User avatar
Posts: 1145
Joined: Fri Jun 04, 2010 4:28 am

Re: Leafkiller's 4.3 Feral Ovale Script

Postby Leafkiller » Thu Dec 15, 2011 7:54 pm

Ah - the issue is with RAVAGEBANG (Ravage!), which is (at least it used to be) the name of the Ravage spell you could cast from Stampede. Prior to that I was displaying a texture since when I displayed Ravage it was greyed out at lower mana levels. Maybe the spellID for Ravage! has changed. I will do a little research. Also, here is a version of the script that uses the texture instead of the spellID:

[code][/code]

Edit: snipped out the test code as this resolved now.

Exalted
User avatar
Posts: 1145
Joined: Fri Jun 04, 2010 4:28 am

Re: Leafkiller's 4.3 Feral Ovale Script

Postby Leafkiller » Thu Dec 15, 2011 8:13 pm

I can find no evidence that Ravage! has a new spell ID (it is 81170). When I look in the combat log it shows Ravage! as having been cast if I hit Ravage after a Feral Charge.

In any event, assuming that the 4.3.5.2 script works for all of you, I will post it as the script to use. I prefer using the actual spell ID for what is being displayed but it is easy to believe that something has changed in how Blizzard is handling the Ravage! ability (after all they did add code to it for the 4 piece set bonus) that is causing issues when Ovale tries to display it, and it is certainly easy enough to display the Ravage texture (this is the icon the game uses for Ravage).

Honored
Posts: 97
Joined: Sun May 29, 2011 2:58 am

Re: Leafkiller's 4.3 Feral Ovale Script

Postby Terias » Thu Dec 15, 2011 8:22 pm

Newest update completely fixes ravage.

Thanks for all your hard work on this Leafkiller.

Exalted
User avatar
Posts: 1145
Joined: Fri Jun 04, 2010 4:28 am

Re: Leafkiller's 4.3 Feral Ovale Script

Postby Leafkiller » Thu Dec 15, 2011 8:34 pm

Thanks for the quick feedback - and especially for pointing out that the change was in 4.2.14. That made the issue obvious.

I am posting 4.3.5.2 as the primary script now.

Posts: 6
Joined: Wed Feb 16, 2011 9:41 am

Re: Leafkiller's 4.3 Feral Ovale Script

Postby Warscreamer » Fri Dec 16, 2011 4:57 am

Thanks mate!
I owe you a beer.

BTW is bear fixed in this release?

PreviousNext

Return to Kitty DPS

Who is online

Users browsing this forum: Google Adsense [Bot], Steakbomb, Untamable and 6 guests