Register

MoP Ovale Script - discussion and request for some help

Face-rippin fun.

Moderator: Forum Administrators

Posts: 41
Joined: Fri Aug 24, 2012 7:08 pm

Re: MoP Ovale Script - discussion and request for some help

Postby Yriss » Fri Aug 24, 2012 7:16 pm

Dream of cenarius: healing buff (spellid 108382). Icon: http://mop.wowhead.com/spell=108382
Dream of cenarius: damage buff (spellid 108381). Icon: http://mop.wowhead.com/spell=108381

Exalted
User avatar
Posts: 1658
Joined: Mon May 24, 2010 10:21 pm

Re: MoP Ovale Script - discussion and request for some help

Postby Tinderhoof » Fri Aug 24, 2012 7:42 pm

Awesome. Thanks Yriss.

Exalted
User avatar
Posts: 1145
Joined: Fri Jun 04, 2010 4:28 am

Re: MoP Ovale Script - discussion and request for some help

Postby Leafkiller » Tue Aug 28, 2012 12:53 am

The MoP version of Ovale has an amazing new capability - it can import Simulationcraft scripts and convert them directly to Ovale scripts. I just checked out the 5.0.0-beta2 version of Ovale on Beta, and the script itself is right out of what we have been developing. Unfortunately, I was unable to test how playable it is because some of the spell IDs of spells has changed in MoP. For example Savage Roar used to be 52610 but in MoP it is now 127538. The beta Ovale code is currently using the old spell ID for Savage Roar, so pretty much all it does is ask you to keep recasting it. I opened a ticket on the Ovale Tickets page reporting this, so hopefully this will be corrected soon.

I will check the rotation tomorrow after the servers come back up and if there are any issues, I will post something that works, but my hope is that the default Ovale script will be usable. Longer term, my focus will be on tuning the simulationcraft script directly so that Ovale can get the rotation directly from there.

The downside is that Ovale is currently only picking up scripts that exists, so there are only Feral and Balance profiles, and no Guardian or Resto rotatios (not sure if anyone would ever be able to use a resto rotation though).

Exalted
User avatar
Posts: 1351
Joined: Fri Nov 25, 2011 7:49 pm

Re: MoP Ovale Script - discussion and request for some help

Postby aggixx » Tue Aug 28, 2012 12:59 am

If I remember correctly from my messing around on beta, savage roar is still the same ID as it is on live, but Savagery has it's own spell ID that's probably the 127 number you listed. I could be wrong.

PS: If that feature actually works well... that's amazing.
Image

Exalted
User avatar
Posts: 1145
Joined: Fri Jun 04, 2010 4:28 am

Re: MoP Ovale Script - discussion and request for some help

Postby Leafkiller » Tue Aug 28, 2012 1:05 am

aggixx wrote:If I remember correctly from my messing around on beta, savage roar is still the same ID as it is on live, but Savagery has it's own spell ID that's probably the 127 number you listed. I could be wrong.

PS: If that feature actually works well... that's amazing.


I checked the spell ID today - and verified it when I was testing out the new Ovale script which was stuck asking me for Savage Roar because it never detected the buff. The more interesting thing I found is that the same spells have different ids depending on the mastery. For example Incarnation is different for Boomkins vs. Ferals. Berserk is now 106951 for Ferals and 106952 for Guardian.

Posts: 47
Joined: Sun Oct 03, 2010 12:13 pm

Re: MoP Ovale Script - discussion and request for some help

Postby mineko » Tue Aug 28, 2012 10:40 pm

Anyone else having issues with Ovale, even after updating? It just won't show up, no matter what settings I fiddle with.

Exalted
User avatar
Posts: 1658
Joined: Mon May 24, 2010 10:21 pm

Re: MoP Ovale Script - discussion and request for some help

Postby Tinderhoof » Tue Aug 28, 2012 10:51 pm

You are still using your old 4.3 script. It is not valid anymore and is why Ovale isn't showing up.

Posts: 47
Joined: Sun Oct 03, 2010 12:13 pm

Re: MoP Ovale Script - discussion and request for some help

Postby mineko » Tue Aug 28, 2012 11:31 pm

I switched to Nerian's scripts and it wouldn't show up for them either. I had thought they were 5.0 ready, but perhaps not.

Exalted
User avatar
Posts: 1145
Joined: Fri Jun 04, 2010 4:28 am

Re: MoP Ovale Script - discussion and request for some help

Postby Leafkiller » Tue Aug 28, 2012 11:45 pm

A lot of things are broken in Ovale right now. First off, you need to get the 5.0 version, which is a beta version that is not completely working. Here is a link to the most recent version of Ovale: http://wow.curseforge.com/addons/ovale/ ... 0-0-beta2/

Install it, open the code page and hit the "Resote Default" button to nuke any existing custom script. Also, turn off Nerian's addon.

Here is a feral only script that is more or less working. Make sure you have every spell on a bar somewhere. I have a macro that includes "/cast Berserk" in it, and every time I log out and log back in, it switches the spell to be the Guardian version on my bar where the macro is and then the feral script will not recognize Berserk since it is looking for the feral version. I simply dragged the feral version onto my bars elsewhere and that is no longer an issue for me.

Go ahead and play with this script and let me know what weird things you are seeing. For the moment I simplified the script a lot - the small frames are fixed in what they show and I removed the look ahead icon because I was getting a lot of lag. Once the patch settles down I will try putting that back in.

EDIT: this script assumes you are using Glyph of Savagery and Glyph of Shred.

Spoiler: show
Code: Select all
# Ovale Optimized Script Leafkiller 5.4
# Ovale source: http://wow.curse.com/downloads/wow-addons/details/ovale.aspx
# Cat Rotation based on Simulationcraft single target default script. Contributions to that have come from many ferals.
# Revision History
# 5.4.1   08/27/2012 First version for patch 5.4 - leaving out Guardian and Feral/Bear for the moment
#                    Assume Glyph of Rake and Glyph of Shred
#                    TargetDeadIn seems to be having issues - so removing the calls for now. Won't affect most combat

Define(BERSERK 106951) #cat+bear cd buff
Define(FAERIEFERAL 770) #bear+cat
Define(FEROCIOUSBITE 22568) #cat finish 35-70 mana
Define(MAIM 22570) #cat interrupt
Define(MANGLECAT 33876) #cat bleed+debuff
   SpellInfo(MANGLECAT inccounter=ripshreds)
Define(RAKE 1822) #cat bleed
Define(RIP 1079) #cat bleed
   SpellInfo(RIP resetcounter=ripshreds)
Define(SAVAGEROAR 127538) #cat damage buff
Define(SHRED 5221) #cat behind
    SpellInfo(SHRED inccounter=ripshreds)
Define(SKULLBASHCAT 80965) #cat interrupt
Define(TIGERSFURY 5217) #cat buff


Define(cat_form 768)
  SpellAddBuff(cat_form cat_form=1)
Define(mark_of_the_wild 1126)
  SpellInfo(mark_of_the_wild duration=3600 )
  SpellAddBuff(mark_of_the_wild mark_of_the_wild=1)
Define(ravage 6785)
  SpellInfo(ravage energy=45 combo=1 )
  SpellInfo(ravage inccounter=ripshreds)
Define(incarnation 102543)
  SpellInfo(incarnation duration=30 cd=180 )
Define(treants 106737)
  SpellInfo(treants duration=15 cd=60 )
Define(weakened_armor 113746)
  SpellInfo(weakened_armor duration=30 )
  SpellAddBuff(weakened_armor weakened_armor=1)
Define(dream_of_cenarius_talent 17)
Define(force_of_nature_talent 12)
Define(incarnation_talent 11)
Define(natures_swiftness_talent 4)
Define(natures_vigil_talent 18)

#Buff
Define(CLEARCASTING 16870)

AddCheckBox(berserk "Cat Berserk" default mastery=2)
AddCheckBox(cooldownsL "Show Left Rotation Boxes" default mastery=2)
AddCheckBox(cooldownsR "Show Right Cooldown Boxes" default mastery=2)
AddCheckBox(lucioles SpellName(FAERIEFERAL) default mastery=2)
AddCheckBox(shred "Use Shred for fillers"  default mastery=2)

AddFunction AddCombo
{
   Spell(ravage usable=1)
   if BuffPresent(TIGERSFURY) or BuffPresent(BERSERK) or CheckBoxOn(shred) Spell(SHRED)
   Spell(MANGLECAT)
}
4
AddFunction BITWRange
{
   {ArmorSetParts(T13 more 1) and TargetLifePercent(less 60)} or TargetLifePercent(less 25)
}
 
AddIcon help=cd size=small mastery=2 { # TF Icon or Barkskin for Bear
    if CheckBoxOn(cooldownsL) {
        if TargetIsInterruptible(yes) {
            Spell(SKULLBASHCAT)
            if ComboPoints(more 1)
                Spell(MAIM)
        }

        if Threat(more 90 target=target) and TargetInRange(COWER)
            Spell(COWER)
    }
}
AddIcon help=cd size=small mastery=2 { # Berserk Icon
    if CheckBoxOn(cooldownsL) {
        if BuffPresent(TIGERSFURY) Spell(BERSERK)
        if 0s before Spell(BERSERK) Texture(Ability_mount_polarbear_white)
    }
}
# Main rotation
AddIcon help=main mastery=2 {
    # Savage Roar
    if BuffRemains(SAVAGEROAR) <=1 or {ComboPoints(more 0) and ComboPoints(less 5) and BuffExpires(SAVAGEROAR 3)} {
        Spell(SAVAGEROAR)
    }
   
    # TF + Berserk logic - only show Berserk if both are off of cooldown - everyone should macro TF to their Berserk key
    if not {BuffPresent(BERSERK) or BuffPresent(CLEARCASTING)} {
        if ArmorSetParts(T13 more 3) {
            if Energy(less 46) and {0s before Spell(TIGERSFURY)} {
                if CheckBoxOn(berserk) Spell(BERSERK)
                Spell(TIGERSFURY)
            }
        } 
        if not ArmorSetParts(T13 more 3) {
            if Energy(less 35) and {0s before Spell(TIGERSFURY)} {
                if CheckBoxOn(berserk) Spell(BERSERK)
                Spell(TIGERSFURY)
            }
        }
    }
   
    #In case Berserk was not cast with TF
    if BuffPresent(TIGERSFURY) and CheckBoxOn(berserk) {
        Spell(BERSERK)
    }
   
    if not TargetInRange(SHRED) {
        Texture(ability_druid_catformattack)
    }

    if CheckBoxOn(lucioles) and target.DebuffStacks(weakened_armor) <3 {
        Spell(FAERIEFERAL)
    }

    # Two conditions for FB during Blood of the Water phase
    # Add in FB code for end of fight - only do this is Rip buff is present
    if BITWRange() and TargetDebuffPresent(RIP mine=1) {
        if ComboPoints(more 4) Spell(FEROCIOUSBITE)
        if ComboPoints(more 0) and TargetDebuffExpires(RIP 2.9 mine=1) Spell(FEROCIOUSBITE)       
    }
    #Extends Rip with shred/mangle/ravage
    if TargetDebuffPresent(RIP mine=1) and TargetDebuffExpires(RIP 4 mine=1) and Counter(ripshreds less 3) AddCombo()
   
    # Time to recast Rip - clip if possible - try to hold off for TF       
    if ComboPoints() >=5 and TargetDebuffExpires(RIP 2 mine=1) and {BuffPresent(BERSERK) or target.DebuffRemains(RIP mine=1)+1.9 <=SpellCooldown(TIGERSFURY) }
        Spell(RIP)

    # FBs during Berserk
    if BuffPresent(BERSERK) {
        if ComboPoints(more 4) and Energy(more 12) and TargetDebuffPresent(RIP 5 mine=1) and BuffPresent(SAVAGEROAR 3) {
            Spell(FEROCIOUSBITE)
        }
    }

    # clip Rake early if TF is up and rake ramining is less than 9 seconds
    if TargetDebuffExpires(RAKE 8.9 mine=1) and BuffPresent(TIGERSFURY) {
        Spell(RAKE)
    }
   
    # intentionally clip Rake to maximize uptime
    if TargetDebuffExpires(RAKE 2.9 mine=1) and {BuffPresent(BERSERK) or Energy(more 70) or {SpellCooldown(tigers_fury) +0.8 } >=target.DebuffRemains(RAKE) }
        Spell(RAKE)

    if BuffPresent(CLEARCASTING) AddCombo()

    # Burn combo points on FB if the target is about to die - on a boss fight this is redundant with BotW phase
    if ComboPoints(more 4) and TargetDeadIn(less 7) {
        Spell(FEROCIOUSBITE)
    }
   
    # Shred aggressively for Berserk and TF
    if BuffPresent(BERSERK) or BuffPresent(TIGERSFURY) AddCombo()
   
    # Shred for combo points for Rip or SR
    if ComboPoints(less 5) and TargetDebuffExpires(RIP 3 mine=1) AddCombo()
    if ComboPoints(less 1) and BuffExpires(SAVAGEROAR 2) AddCombo()
   
    # Shred to burn off energy so we can TF without capping
    if { 3s before Spell(TIGERSFURY) } AddCombo()
   
    # Shred is the mob will die within one Rake
    if TargetDeadIn(less 8.5) AddCombo()
   
    # Fallback Shred to prevent energy capping
    if 1.2s before Energy(more 99) AddCombo()
}


AddIcon help=cd size=small mastery=2 { # Rake/Manglebear Icon
    if CheckBoxOn(cooldownsR) {
        if BuffExpires(SAVAGEROAR 0) Spell(SAVAGEROAR)
    }
}
AddIcon help=cd size=small mastery=2 { # Rip/Swipebear Icon
    if CheckBoxOn(cooldownsR) {
        if TargetDebuffExpires(RIP 0 mine=1) Spell(RIP)
    }
}
AddIcon help=cd size=small mastery=2 { # Rake/Manglebear Icon
    if CheckBoxOn(cooldownsR) {
        if TargetDebuffExpires(RAKE 0 mine=1) Spell(RAKE)
    }
}
AddIcon help=cd size=small mastery=2 { # Rip/Swipebear Icon
    if CheckBoxOn(cooldownsR) {
        Spell(TIGERSFURY)
    }
}

Posts: 47
Joined: Sun Oct 03, 2010 12:13 pm

Re: MoP Ovale Script - discussion and request for some help

Postby mineko » Wed Aug 29, 2012 1:29 am

I've installed the beta Ovale and have been playing with your script against target dummies, and the only thing I found odd so far is it's suggesting for me to berserk without tiger's fury. I may be missing something though. Do these no longer synergize well together? Or does the script assume you'll hit tiger's fury when it suggests berserk as a given?

If my second assumption turns out to be right, given the new T13 4-piece bonus (free OoC proc upon casting tiger's fury) wouldn't it make more sense to wait until after wasting the clearcast on a shred or something before hitting berserk? It seems like if you hit berserk with the guaranteed OoC proc from tiger's fury still active, you'll be wasting energy and valuable berserk time.

Exalted
User avatar
Posts: 1145
Joined: Fri Jun 04, 2010 4:28 am

Re: MoP Ovale Script - discussion and request for some help

Postby Leafkiller » Wed Aug 29, 2012 1:50 am

New version of the script with a basic version of a Guardian rotation and some small changes to make it more robust per a conversation I am having with Tinderhoof. The first large icon shows the rage generation rotation and the second icon shows defensive spells. If Rage is less than 60 it shows Frenzied, otherwise it shows SD. You can use this as a guide. Not sure what happens if you glyph Frenzied though...
Spoiler: show
Code: Select all
# Ovale Optimized Script Leafkiller 5.4
# Ovale source: http://wow.curse.com/downloads/wow-addons/details/ovale.aspx
# Cat Rotation based on Simulationcraft single target default script. Contributions to that have come from many ferals.
# Revision History
# 5.4.3   08/28/2012 Misc small changes to make it more robust per discussion with Tinderhoof
# 5.4.2   08/28/2012 Rudimentary Bear stuff - I need someway to track Mangle...
# 5.4.1   08/27/2012 First version for patch 5.4 - leaving out Guardian and Feral/Bear for the moment
#                    Assume Glyph of Rake and Glyph of Shred
#                    TargetDeadIn seems to be having issues - so removing the calls for now. Won't affect most combat

Define(BERSERK 106951) #cat+bear cd buff
Define(FAERIEFERAL 770) #bear+cat
Define(FEROCIOUSBITE 22568) #cat finish 35-70 mana
Define(MAIM 22570) #cat interrupt
Define(MANGLECAT 33876) #cat bleed+debuff
   SpellInfo(MANGLECAT inccounter=ripshreds)
Define(RAKE 1822) #cat bleed
Define(RIP 1079) #cat bleed
   SpellInfo(RIP resetcounter=ripshreds)
Define(SAVAGEROAR 127538) #cat damage buff
Define(SHRED 5221) #cat behind
    SpellInfo(SHRED inccounter=ripshreds)
Define(SKULLBASHCAT 80965) #cat interrupt
Define(TIGERSFURY 5217) #cat buff

Define(BERSERKBEAR 106952) #cat+bear cd buff
  SpellInfo(BERSERKBEAR duration=10 cd=180 )
  SpellAddBuff(BERSERKBEAR BERSERKBEAR=1)
Define(MANGLEBEAR 33878)
Define(LACERATE 33745)
Define(FRENZIEDREGEN 22842)
Define(INCARNATIONBEAR 102558)
Define(MAUL 6807)
Define(MIGHTOFURSOC 106922)
Define(RENEWAL 108238)
Define(SAVAGEDEFENSE 62606)
Define(SURVIVALINSTINCTS 61336)
Define(SWIPEBEAR 779)
Define(THRASHBEAR 77758)
Define(BARKSKIN 22812)
Define(ENRAGE 5229)

Define(cat_form 768)
  SpellAddBuff(cat_form cat_form=1)
Define(mark_of_the_wild 1126)
  SpellInfo(mark_of_the_wild duration=3600 )
  SpellAddBuff(mark_of_the_wild mark_of_the_wild=1)
Define(ravage 6785)
  SpellInfo(ravage energy=45 combo=1 )
  SpellInfo(ravage inccounter=ripshreds)
Define(incarnation 102543)
  SpellInfo(incarnation duration=30 cd=180 )
Define(treants 106737)
  SpellInfo(treants duration=15 cd=60 )
Define(weakened_armor 113746)
  SpellInfo(weakened_armor duration=30 )
  SpellAddBuff(weakened_armor weakened_armor=1)
Define(weakened_blows 115798)
  SpellInfo(weakened_blows duration=30 )
  SpellAddBuff(weakened_blows weakened_blows=1)
Define(dream_of_cenarius_talent 17)
Define(force_of_nature_talent 12)
Define(incarnation_talent 11)
Define(natures_swiftness_talent 4)
Define(natures_vigil_talent 18)

#Buff
Define(CLEARCASTING 16870)

AddCheckBox(berserk "Cat Berserk" default mastery=2)
AddCheckBox(cooldownsL "Show Left Rotation Boxes" default mastery=2)
AddCheckBox(cooldownsR "Show Right Cooldown Boxes" default mastery=2)
AddCheckBox(lucioles SpellName(FAERIEFERAL) default mastery=2)
AddCheckBox(shred "Use Shred for fillers"  default mastery=2)



AddIcon help=cd size=small mastery=3 {
    Spell(BARKSKIN)
}

AddIcon help=cd size=small mastery=3 {
    Spell(RENEWAL)
}

# Main rotation
AddIcon help=main mastery=3 {   
    if 1s before Spell(MANGLEBEAR) Spell(MANGLEBEAR)

    if target.DebuffStacks(weakened_armor) <1 Spell(FAERIEFERAL)
   
    if not TargetDebuffPresent(weakened_blows) Spell(THRASHBEAR)
   
    Spell(LACERATE)
}

AddIcon help=defense mastery=3 {
    Spell(SAVAGEDEFENSE usable=1)
    Spell(FRENZIEDREGEN)
}

AddIcon help=cd size=small mastery=3 {
    Spell(SURVIVALINSTINCTS)
}

AddIcon help=cd size=small mastery=3 {
    Spell(MIGHTOFURSOC)
}

AddIcon help=cd size=small mastery=3 {
    Spell(ENRAGE)
}

AddIcon help=cd size=small mastery=3 {
    Spell(BERSERKBEAR)
}

AddFunction AddCombo
{
   if TalentPoints(incarnation_talent) Spell(ravage usable=1)
   if BuffPresent(TIGERSFURY) or BuffPresent(BERSERK) or CheckBoxOn(shred) Spell(SHRED)
    Spell(MANGLECAT)
}
4
AddFunction BITWRange
{
   {ArmorSetParts(T13 more 1) and TargetLifePercent(less 60)} or TargetLifePercent(less 25)
}
 
AddIcon help=cd size=small mastery=2 { # TF Icon or Barkskin for Bear
    if CheckBoxOn(cooldownsL) {
        if TargetIsInterruptible(yes) {
            Spell(SKULLBASHCAT)
            if ComboPoints(more 1)
                Spell(MAIM)
        }

        if Threat(more 90 target=target) and TargetInRange(COWER)
            Spell(COWER)
    }
}
AddIcon help=cd size=small mastery=2 { # Berserk Icon
    if CheckBoxOn(cooldownsL) {
        if BuffPresent(TIGERSFURY) Spell(BERSERK)
        if 0s before Spell(BERSERK) Texture(Ability_mount_polarbear_white)
    }
}
# Main rotation
AddIcon help=main mastery=2 {
    # Savage Roar
    if BuffRemains(SAVAGEROAR) <=1 or {ComboPoints(more 0) and ComboPoints(less 5) and BuffExpires(SAVAGEROAR 3)} {
        Spell(SAVAGEROAR)
    }
   
    # TF + Berserk logic - only show Berserk if both are off of cooldown - everyone should macro TF to their Berserk key
    if not {BuffPresent(BERSERK) or BuffPresent(CLEARCASTING)} {
        if ArmorSetParts(T13 more 3) {
            if Energy(less 46) and {0s before Spell(TIGERSFURY)} {
                if CheckBoxOn(berserk) Spell(BERSERK)
                Spell(TIGERSFURY)
            }
        } 
        if not ArmorSetParts(T13 more 3) {
            if Energy(less 35) and {0s before Spell(TIGERSFURY)} {
                if CheckBoxOn(berserk) Spell(BERSERK)
                Spell(TIGERSFURY)
            }
        }
    }
   
    #In case Berserk was not cast with TF
    if BuffPresent(TIGERSFURY) and CheckBoxOn(berserk) {
        Spell(BERSERK)
    }
   
    if not TargetInRange(SHRED) {
        Texture(ability_druid_catformattack)
    }

    if CheckBoxOn(lucioles) and target.DebuffStacks(weakened_armor) <1 {
        Spell(FAERIEFERAL)
    }

    # Two conditions for FB during Blood of the Water phase
    # Add in FB code for end of fight - only do this is Rip buff is present
    if BITWRange() and TargetDebuffPresent(RIP mine=1) {
        if ComboPoints(more 4) Spell(FEROCIOUSBITE)
        if ComboPoints(more 0) and TargetDebuffExpires(RIP 2.9 mine=1) Spell(FEROCIOUSBITE)       
    }
    #Extends Rip with shred/mangle/ravage
    if TargetDebuffPresent(RIP mine=1) and TargetDebuffExpires(RIP 4 mine=1) and Counter(ripshreds less 3) AddCombo()
   
    # Time to recast Rip - clip if possible - try to hold off for TF       
    if ComboPoints() >=5 and TargetDebuffExpires(RIP 2 mine=1) and {BuffPresent(BERSERK) or target.DebuffRemains(RIP mine=1)+1.9 <=SpellCooldown(TIGERSFURY) }
        Spell(RIP)

    # FBs during Berserk
    if BuffPresent(BERSERK) {
        if ComboPoints(more 4) and Energy(more 12) and TargetDebuffPresent(RIP 5 mine=1) and BuffPresent(SAVAGEROAR 3) {
            Spell(FEROCIOUSBITE)
        }
    }

    # clip Rake early if TF is up and rake ramining is less than 9 seconds
    if TargetDebuffExpires(RAKE 8.9 mine=1) and BuffPresent(TIGERSFURY) {
        Spell(RAKE)
    }
   
    # intentionally clip Rake to maximize uptime
    if TargetDebuffExpires(RAKE 2.9 mine=1) and {BuffPresent(BERSERK) or Energy(more 70) or {SpellCooldown(tigers_fury) +0.8 } >=target.DebuffRemains(RAKE) }
        Spell(RAKE)

    if BuffPresent(CLEARCASTING) AddCombo()

    # Burn combo points on FB if the target is about to die - on a boss fight this is redundant with BotW phase
    if ComboPoints(more 4) and TargetDeadIn(less 7) {
        Spell(FEROCIOUSBITE)
    }
   
    # Shred aggressively for Berserk and TF
    if BuffPresent(BERSERK) or BuffPresent(TIGERSFURY) AddCombo()
   
    # Shred for combo points for Rip or SR
    if ComboPoints(less 5) and TargetDebuffExpires(RIP 3 mine=1) AddCombo()
    if ComboPoints(less 1) and BuffExpires(SAVAGEROAR 2) AddCombo()
   
    # Shred to burn off energy so we can TF without capping
    if { 3s before Spell(TIGERSFURY) } AddCombo()
   
    # Shred is the mob will die within one Rake
    if TargetDeadIn(less 8.5) AddCombo()
   
    # Fallback Shred to prevent energy capping
    if 1.2s before Energy(more 99) AddCombo()
}


AddIcon help=cd size=small mastery=2 { # Rake/Manglebear Icon
    if CheckBoxOn(cooldownsR) {
        if BuffExpires(SAVAGEROAR 0) Spell(SAVAGEROAR)
    }
}
AddIcon help=cd size=small mastery=2 { # Rip/Swipebear Icon
    if CheckBoxOn(cooldownsR) {
        if TargetDebuffExpires(RIP 0 mine=1) Spell(RIP)
    }
}
AddIcon help=cd size=small mastery=2 { # Rake/Manglebear Icon
    if CheckBoxOn(cooldownsR) {
        if TargetDebuffExpires(RAKE 0 mine=1) Spell(RAKE)
    }
}
AddIcon help=cd size=small mastery=2 { # Rip/Swipebear Icon
    if CheckBoxOn(cooldownsR) {
        Spell(TIGERSFURY)
    }
}

Exalted
User avatar
Posts: 1145
Joined: Fri Jun 04, 2010 4:28 am

Re: MoP Ovale Script - discussion and request for some help

Postby Leafkiller » Wed Aug 29, 2012 1:52 am

mineko wrote:I've installed the beta Ovale and have been playing with your script against target dummies, and the only thing I found odd so far is it's suggesting for me to berserk without tiger's fury. I may be missing something though. Do these no longer synergize well together? Or does the script assume you'll hit tiger's fury when it suggests berserk as a given?

If my second assumption turns out to be right, given the new T13 4-piece bonus (free OoC proc upon casting tiger's fury) wouldn't it make more sense to wait until after wasting the clearcast on a shred or something before hitting berserk? It seems like if you hit berserk with the guaranteed OoC proc from tiger's fury still active, you'll be wasting energy and valuable berserk time.


You have selected the "Berserk" option. The script assumes you are using a macro to cast TF with Berserk so when it wants you to cast both it shows you Berserk.

Site Admin
User avatar
Posts: 288
Joined: Tue Mar 16, 2010 3:05 pm

Re: MoP Ovale Script - discussion and request for some help

Postby Alaron » Wed Aug 29, 2012 2:34 am

FYI, I just added spoiler BBcodes. LK and others, it'd be helpful if you wrapped big text blocks in the spoiler tag to make the thread a bit easier to read. I tested it on your first script and it looks like it worked fine. :)

Exalted
User avatar
Posts: 1351
Joined: Fri Nov 25, 2011 7:49 pm

Re: MoP Ovale Script - discussion and request for some help

Postby aggixx » Wed Aug 29, 2012 6:08 am

Some feedback:
Leafkiller wrote:
Spoiler: show
Code: Select all
    # Savage Roar
    if BuffRemains(SAVAGEROAR) <=1 or {ComboPoints(more 0) and ComboPoints(less 5) and BuffExpires(SAVAGEROAR 3)} {
        Spell(SAVAGEROAR)
    }

If the ComboPoints(less 5) part is derived from the SimC rotation, you can probably safely remove it. I put that there as a lazy way of making sure SR wasn't sniping DoCs from 5pt finishers.

Leafkiller wrote:
Spoiler: show
Code: Select all
    # TF + Berserk logic - only show Berserk if both are off of cooldown - everyone should macro TF to their Berserk key
    if not {BuffPresent(BERSERK) or BuffPresent(CLEARCASTING)} {
        if ArmorSetParts(T13 more 3) {
            if Energy(less 46) and {0s before Spell(TIGERSFURY)} {
                if CheckBoxOn(berserk) Spell(BERSERK)
                Spell(TIGERSFURY)
            }
        } 
        if not ArmorSetParts(T13 more 3) {
            if Energy(less 35) and {0s before Spell(TIGERSFURY)} {
                if CheckBoxOn(berserk) Spell(BERSERK)
                Spell(TIGERSFURY)
            }
        }
    }

Umm, isn't this backwards? The energy threshold should be lower with 4pT13, not the other way around.

Leafkiller wrote:
Spoiler: show
Code: Select all
    if CheckBoxOn(lucioles) and target.DebuffStacks(weakened_armor) <1 {
        Spell(FAERIEFERAL)
    }

Seems like the FF code could be a lot more aggressive than this, making it toss a FF whenever it's got a free GCD (probably only when duration is less than 15 or so) makes it a lot less likely to interfere with the rotation.

Besides the above points, I can't help but feel that there's some serious bug in the script. It never ever tells me pool, it's always telling me to shred. It often doesn't tell me to refresh rake until the absolute last second, and I've seen a couple times (on the 1 HP training dummy, possibly has something to do with it) where it tells me to FB at incredibly dumb times. To be specific, there was one instance where my rip and SR were both about to fall of (3 seconds-ish) and it told me to use FB. Edit: See below!

Edit: Oh also, I feel that it would benefit from a SR/Rip desync line. Just a hunch though.
Edit 2: After some brief testing, I guess the non-raid boss dummies having 1 HP screws with it and it seems to think the target is going to die all the time. How unfortunate.
Image

Honored
Posts: 145
Joined: Thu Mar 18, 2010 12:33 am
Location: Melbourne, Australia

Re: MoP Ovale Script - discussion and request for some help

Postby Grenache » Wed Aug 29, 2012 8:59 am

Hi guys,

I used the script tonight and yes, there is something wrong with the FB suggestions. They were often just when Rip was about to drop off, and it caught me out a few times.

Exalted
User avatar
Posts: 1658
Joined: Mon May 24, 2010 10:21 pm

Re: MoP Ovale Script - discussion and request for some help

Postby Tinderhoof » Wed Aug 29, 2012 1:29 pm

Seems like the FF code could be a lot more aggressive than this, making it toss a FF whenever it's got a free GCD (probably only when duration is less than 15 or so) makes it a lot less likely to interfere with the rotation.

This is likely on me. I was testing this out in our DS last night and I had to turn off FF because it was suggesting it every 7 seconds (ie off cooldown). Leaf adjusted it to not look at stacks because Ovale seemed to think that we had to ramp it up like Warriors and Rogues. After that adjustment it seemed to work great for me. Personally with current gear I didn't have a lot of down time to put FF up. For the beta I can totally see this as being helpful, but live it maybe more of a hinderence then a help.

After some brief testing, I guess the non-raid boss dummies having 1 HP screws with it and it seems to think the target is going to die all the time.

Ya it trys to estimate time till death so that you don't put up bleeds that will go to long and such.

Exalted
User avatar
Posts: 1145
Joined: Fri Jun 04, 2010 4:28 am

Re: MoP Ovale Script - discussion and request for some help

Postby Leafkiller » Wed Aug 29, 2012 2:41 pm

aggixx wrote:If the ComboPoints(less 5) part is derived from the SimC rotation, you can probably safely remove it. I put that there as a lazy way of making sure SR wasn't sniping DoCs from 5pt finishers.


I actually started without that but I was having trouble getting Rip up so I decided to try and limit SR some. It was in lieu of the desync code which I took out because what I had was not appropriate to what we should be doing now. I may try to put some desync code back in, but I will have to look at what is an appropriate way to do it. I don't suppose we have an easy way to do sims on a level 85 T13 toon?

aggixx wrote:Umm, isn't this backwards? The energy threshold should be lower with 4pT13, not the other way around.

That was based on the old tier 13 Ravage proc. Honestly, I had not even looked at what the new T13 4 piece proc was for cat until just now...

aggixx wrote:Seems like the FF code could be a lot more aggressive than this, making it toss a FF whenever it's got a free GCD (probably only when duration is less than 15 or so) makes it a lot less likely to interfere with the rotation.


As Tinder mentioned, the script is getting hung up on FF sometimes. I had to disable it while I was in LFR. I was hoping that lowering the threshold would stop it from trying to fire multiple times in a row. I think it may be due to others putting up the armor debuff at the same time. It would be possible to add a FF conditional at the end of the filler section that called for it when the script is pooling energy.

I think the other issues you saw were due to being on the 1 hp dummy.

Exalted
User avatar
Posts: 1351
Joined: Fri Nov 25, 2011 7:49 pm

Re: MoP Ovale Script - discussion and request for some help

Postby aggixx » Wed Aug 29, 2012 5:54 pm

Leafkiller wrote:I don't suppose we have an easy way to do sims on a level 85 T13 toon?

Yep, just download the most recent version (either pre-compiled or self compiled should work just fine). You should be able to find the T13H profile in the profiles folder and edit it from there. The rotation's kind of a mess though since it's trying to do the whole super rip thing (it was like a 2k DPS gain! =P).

Leafkiller wrote:I think the other issues you saw were due to being on the 1 hp dummy.

Yeah, I agree. I'll have to see if I can hack/ticket it to get it fixed, because not being able to try to rotation on a dummy that isn't dodging you every other attack is really annoying >.>
Image

Revered
Posts: 387
Joined: Tue Feb 08, 2011 5:51 pm

Re: MoP Ovale Script - discussion and request for some help

Postby ShmooDude » Wed Aug 29, 2012 8:15 pm

@Leafkiller Neither version of your 5.4 scripts seem to work for me. It functions except it doesn't recognize savage roar at all. After reading:

aggixx wrote:If I remember correctly from my messing around on beta, savage roar is still the same ID as it is on live, but Savagery has it's own spell ID that's probably the 127 number you listed. I could be wrong.

PS: If that feature actually works well... that's amazing.


I manually edited the script with the following changes:

...
Define(SAVAGEROAR 52610) #cat damage buff
...
Define(savage_roar 127538)
...
# Savage Roar
if BuffRemains(savage_roar) <=1 or {ComboPoints(more 0) and ComboPoints(less 5) and BuffExpires(savage_roar 3)} {
Spell(SAVAGEROAR)
}
...
# FBs during Berserk
if BuffPresent(BERSERK) {
if ComboPoints(more 4) and Energy(more 12) and TargetDebuffPresent(RIP 5 mine=1) and BuffPresent(savage_roar 3) {
Spell(FEROCIOUSBITE)
}
...
# Shred for combo points for Rip or SR
if ComboPoints(less 5) and TargetDebuffExpires(RIP 3 mine=1) AddCombo()
if ComboPoints(less 1) and BuffExpires(savage_roar 2) AddCombo()
...
AddIcon help=cd size=small mastery=2 { # Rake/Manglebear Icon
if CheckBoxOn(cooldowns) {
if BuffExpires(savage_roar 0) Spell(SAVAGEROAR)
}
}

Basically replacing every mention of SAVAGEROAR with savage_roar when its referencing a buff check but leaving SAVAGEROAR for anything referencing the ability itself.

This is the only way I could get it to work, is it like this for anyone else?

EDIT: Also, we don't have cower anymore (Unless there's some trick to getting it, lol) so the cower code for the top left icon is superfluous.

Posts: 3
Joined: Wed Aug 29, 2012 8:52 pm

Re: MoP Ovale Script - discussion and request for some help

Postby Vekz » Wed Aug 29, 2012 9:34 pm

ShmooDude wrote:@Leafkiller Neither version of your 5.4 scripts seem to work for me. It functions except it doesn't recognize savage roar at all. After reading:

aggixx wrote:If I remember correctly from my messing around on beta, savage roar is still the same ID as it is on live, but Savagery has it's own spell ID that's probably the 127 number you listed. I could be wrong.

PS: If that feature actually works well... that's amazing.


I manually edited the script with the following changes:

...
Define(SAVAGEROAR 52610) #cat damage buff
...
Define(savage_roar 127538)
...
# Savage Roar
if BuffRemains(savage_roar) <=1 or {ComboPoints(more 0) and ComboPoints(less 5) and BuffExpires(savage_roar 3)} {
Spell(SAVAGEROAR)
}
...
# FBs during Berserk
if BuffPresent(BERSERK) {
if ComboPoints(more 4) and Energy(more 12) and TargetDebuffPresent(RIP 5 mine=1) and BuffPresent(savage_roar 3) {
Spell(FEROCIOUSBITE)
}
...
# Shred for combo points for Rip or SR
if ComboPoints(less 5) and TargetDebuffExpires(RIP 3 mine=1) AddCombo()
if ComboPoints(less 1) and BuffExpires(savage_roar 2) AddCombo()
...
AddIcon help=cd size=small mastery=2 { # Rake/Manglebear Icon
if CheckBoxOn(cooldowns) {
if BuffExpires(savage_roar 0) Spell(SAVAGEROAR)
}
}

Basically replacing every mention of SAVAGEROAR with savage_roar when its referencing a buff check but leaving SAVAGEROAR for anything referencing the ability itself.

This is the only way I could get it to work, is it like this for anyone else?

EDIT: Also, we don't have cower anymore (Unless there's some trick to getting it, lol) so the cower code for the top left icon is superfluous.


These edits worked perfectly for SR!

Posts: 6
Joined: Wed Aug 29, 2012 5:46 pm

Re: MoP Ovale Script - discussion and request for some help

Postby Pheratia » Wed Aug 29, 2012 9:40 pm

the bear portion keeps saying to lacerate, even while it's on cooldown

Exalted
User avatar
Posts: 1145
Joined: Fri Jun 04, 2010 4:28 am

Re: MoP Ovale Script - discussion and request for some help

Postby Leafkiller » Wed Aug 29, 2012 9:47 pm

@ShmooDude,

In the spellbook for ferals savage roar is 127538. When you cast it the buff is also 127538. One weird thing I suggest is that you drag the icon from the spell book over whatever is on your bars to make sure you have the latest greatest. Ovale needs each spell on the spell bar to work properly.

I will remove cower next time I make changes.

Exalted
User avatar
Posts: 1145
Joined: Fri Jun 04, 2010 4:28 am

Re: MoP Ovale Script - discussion and request for some help

Postby Leafkiller » Wed Aug 29, 2012 9:51 pm

Pheratia wrote:the bear portion keeps saying to lacerate, even while it's on cooldown


I will add a "useable=1" to it next time I iterate the script. When you see lacerate there is nothing else to do...

Revered
Posts: 387
Joined: Tue Feb 08, 2011 5:51 pm

Re: MoP Ovale Script - discussion and request for some help

Postby ShmooDude » Thu Aug 30, 2012 6:41 am

Leafkiller wrote:@ShmooDude,

In the spellbook for ferals savage roar is 127538. When you cast it the buff is also 127538. One weird thing I suggest is that you drag the icon from the spell book over whatever is on your bars to make sure you have the latest greatest. Ovale needs each spell on the spell bar to work properly.

I will remove cower next time I make changes.


That did it. It looks like the macro system (I have just about everything under the sun macroed =D) is referencing the old savage roar, whereas if you drag it to the action bar, you get the new version. In the macroed version, SR is permanently faded out (ie darker colored as if its not able to be used at the moment, regardless of combo points). In the non-macroed version, SR always appears usable with glyph and is faded at 0 CPs without the glyph. Skull Bash, Berserk and Wild Charge have similar problems (ie appear faded out all the time, regardless of "usable" or not). Incarnation won't even show up under the macro system. I'm guessing the macro code isn't able to reference mop spell IDs? But not a script or even an ovale problem, that's a Bliz problem. Gonna go make a bug report (assuming someone hasn't made one already).

For now as a stop gap I've put all my cat abilities on bar 10 completely unmacroed then hid it (bar 10 isn't usually accessible anyhow under the normal UI) which should solve any problems related to this bug. Probably only needed Savage Roar (maybe mangle, though it appears to function ok) so anyone else having this problem should do the same. :) (perhaps make a note of it in the official thread so people aren't confused as I was).

Exalted
User avatar
Posts: 1658
Joined: Mon May 24, 2010 10:21 pm

Re: MoP Ovale Script - discussion and request for some help

Postby Tinderhoof » Thu Aug 30, 2012 12:47 pm

Incarnation won't even show up under the macro system.

Not sure what you are talking about here. I had it macro'd to Berserk/TF on Tuesday for Spine. It worked fine for me.

PreviousNext

Return to Kitty DPS

Who is online

Users browsing this forum: Bing [Bot], Dwade, Google Feedfetcher, ShmooDude, Yahoo [Bot] and 4 guests